20260610-linuxkm-fenrir#10676
Merged
Merged
Conversation
…-Test Error Messages
F-1880: Unsigned word32 dec_len Silently Wraps Negative wc_RsaSSL_Verify Error Codes, Returning Wrong Errno on RSA Signature Verification Failure F-1881: word32 sig_len Silently Wraps Negative wc_RsaSSL_Sign Error in Self-Test Functions, Bypassing <= 0 Guard F-1882: word32 priv_len / pub_len Silently Wrap Negative wc_RsaKeyToDer / wc_RsaKeyToPublicDer Errors Across Three RSA Self-Test Functions
also ForceZeros various other potentially sensitive allocations before freeing them, and uses unconditional free() per current libwolfssl best practice.
…or Code to Kernel LKCAPI
in AesGcmCrypt_1() and AesCcmCrypt_1(), check for overflow on assoclen+cryptlen in both encrypt and decrypt modes; in linuxkm_test_kpp_driver(), return MEMORY_E, not -ENOMEM; in km_direct_rsa_dec(), only update req->dst_len for -EOVERFLOW, not for -EINVAL.
…ating skcipher_walk Error
… in km_hmac_init Error Path
…ith Plain Assignment Instead of wc_ForceZero
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10676
Scan targets checked: linuxkm-bugs, linuxkm-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
dgarske
reviewed
Jun 12, 2026
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-securityOverall recommendation: REQUEST_CHANGES
Findings: 4 total — 4 posted, 0 skipped
4 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [High] [review+review-security] wc_ForceZero() called with 3 arguments (compile error / broken entropy zeroization fix) —
linuxkm/module_hooks.c:475 - [Low] [review] Trailing comma instead of period in error message —
linuxkm/lkcapi_aes_glue.c:3643 - [Low] [review-security] km_direct_rsa_dec no longer reports required dst_len on -EINVAL path —
linuxkm/lkcapi_rsa_glue.c:799 - [Info] [review-security] x86_vector_register_glue.c allocation-failure log size argument changed —
linuxkm/x86_vector_register_glue.c:72
Review generated by Skoll
linuxkm/lkcapi_aes_glue.c: fix typo in linuxkm_test_aesgcm() error message.
dgarske
approved these changes
Jun 13, 2026
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for numerous "low" Fenrir issues in linuxkm/. See commit messages for the details.
tested with